Bug 88197 – ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

Consider a file with the following markup:
 
<style>svg { max-height:5%; }</style>
<svg></svg>

Opening this file will cause ASSERT(!isPercentageIntrinsicSize) to fail in RenderReplaced::computeIntrinsicRatioInformationForRenderBox(), <http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderReplaced.cpp?rev=117697#L293>.

[Daniel Bates]

Created attachment 145493 [details]
Example (Will cause assertion failure)

For convenience, a file that contains the markup described in the bug description.

[Joe Thomas]

Looks to me like the assertion ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize to true while it handles width/height of Percentage types. 
I will make a patch to remove this.

[Joe Thomas]

Created attachment 145870 [details]
patch

[Daniel Bates]

Comment on attachment 145870 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145870&action=review

> Source/WebCore/ChangeLog:9
> +        ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
> +        to true while it handles width/height of Percentage types.

It's an undocumented convention that we wrap long lines in change log entries. I suggest adding a new line character after "RenderSVGRoot::computeIntrinsicRatioInformation" in line 8 such that we move the phrase "sets isPercentageIntrinsicSize" onto line 9. You may also want to consider adding a remark that explains that RenderSVGRoot extends RenderReplaced so as to more explicitly imply that RenderSVGRoot overrides RenderReplaced::computeIntrinsicRatioInformation().

Nit: Percentage => percentage
(as it's not a proper noun)

> Source/WebCore/rendering/RenderReplaced.cpp:-293
> -    ASSERT(!isPercentageIntrinsicSize);

Would it make sense to assert !isPercentageIntrinsicSize when intrinsicRatio is non-zero?

> LayoutTests/ChangeLog:9
> +        ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
> +        to true while it handles width/height of Percentage types.

Ditto.

> LayoutTests/svg/in-html/svg-assert-failure-percentage.html:7
> +<svg style= "max-height:5%"> </svg>

Nit: There's a space after the '=' in this line.  I suggest we remove this space so as to be consistent with the spacing (or lack of) on the left side of the equality sign.

> LayoutTests/svg/in-html/svg-assert-failure-percentage.html:8
> +NO Assert!

This output message isn't formatted well. On another note, maybe the following text would be more description:

This test PASSED if it doesn't cause an assertion failure.

[Joe Thomas]

Created attachment 145899 [details]
Patch-Updated

Review comments incorporated

[Joe Thomas]

(In reply to comment #4)
> (From update of attachment 145870 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145870&action=review
> 
Thanks for the review.

> > Source/WebCore/ChangeLog:9
> > +        ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
> > +        to true while it handles width/height of Percentage types.
> 
> It's an undocumented convention that we wrap long lines in change log entries. I suggest adding a new line character after "RenderSVGRoot::computeIntrinsicRatioInformation" in line 8 such that we move the phrase "sets isPercentageIntrinsicSize" onto line 9. You may also want to consider adding a remark that explains that RenderSVGRoot extends RenderReplaced so as to more explicitly imply that RenderSVGRoot overrides RenderReplaced::computeIntrinsicRatioInformation().
> 
> Nit: Percentage => percentage
> (as it's not a proper noun)
> 
Done

> > Source/WebCore/rendering/RenderReplaced.cpp:-293
> > -    ASSERT(!isPercentageIntrinsicSize);
> 
> Would it make sense to assert !isPercentageIntrinsicSize when intrinsicRatio is non-zero?
> 
Yes, I think that is better. Changed.

> > LayoutTests/ChangeLog:9
> > +        ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
> > +        to true while it handles width/height of Percentage types.
> 
> Ditto.
> 
> > LayoutTests/svg/in-html/svg-assert-failure-percentage.html:7
> > +<svg style= "max-height:5%"> </svg>
> 
> Nit: There's a space after the '=' in this line.  I suggest we remove this space so as to be consistent with the spacing (or lack of) on the left side of the equality sign.
> 
> > LayoutTests/svg/in-html/svg-assert-failure-percentage.html:8
> > +NO Assert!
> 
> This output message isn't formatted well. On another note, maybe the following text would be more description:
> 
> This test PASSED if it doesn't cause an assertion failure.

Done.

[Daniel Bates]

Comment on attachment 145899 [details]
Patch-Updated

Thanks Joe for updating the patch. Looks reasonable to me.

[WebKit Review Bot]

Comment on attachment 145899 [details]
Patch-Updated

Clearing flags on attachment: 145899

Committed r119565: <http://trac.webkit.org/changeset/119565>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.