Bug 88154

Summary:

loadRequest should check for empty URLs.

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebKit Misc.

Assignee:

Yongjun Zhang <yongjun_zhang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson, ddkilzer, webkit.review.bot, yongjun_zhang

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

OS X 10.7

Attachments:

Description	Flags
Don't transform empty URLs to file: URL.	none
Don't transform empty URLs to file: URL, update the changeLog with bug id.	beidson: review+
only use isEmpty() as Brady pointed out, since String.isEmpty() also covers the nil URL case.	none

Yongjun Zhang

Reported 2012-06-01 17:07:33 PDT

In [WebFrame loadRequest], we check if the url is valid or nil, if not we transform it to file: url. However, WebKit client could pass down an empty URL and we need to handle that as well.

Attachments
Don't transform empty URLs to file: URL. (2.07 KB, patch) 2012-06-01 17:38 PDT, Yongjun Zhang	no flags	Details Formatted Diff Diff
Don't transform empty URLs to file: URL, update the changeLog with bug id. (2.12 KB, patch) 2012-06-01 17:47 PDT, Yongjun Zhang	beidson: review+	Details Formatted Diff Diff
only use isEmpty() as Brady pointed out, since String.isEmpty() also covers the nil URL case. (2.10 KB, patch) 2012-06-02 10:31 PDT, Yongjun Zhang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2012-06-01 17:09:13 PDT

<rdar://problem/11537160>

Yongjun Zhang

Comment 2 2012-06-01 17:38:50 PDT

Created attachment 145411 [details] Don't transform empty URLs to file: URL.

WebKit Review Bot

Comment 3 2012-06-01 17:42:37 PDT

Attachment 145411 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yongjun Zhang

Comment 4 2012-06-01 17:47:14 PDT

Created attachment 145412 [details] Don't transform empty URLs to file: URL, update the changeLog with bug id.

Brady Eidson

Comment 5 2012-06-01 21:40:10 PDT

Comment on attachment 145412 [details] Don't transform empty URLs to file: URL, update the changeLog with bug id. In WebCore string land, "isEmpty()" covers both null and empty, so I think you can just get rid of [request URL] altogether.

Yongjun Zhang

Comment 6 2012-06-02 10:31:48 PDT

Created attachment 145451 [details] only use isEmpty() as Brady pointed out, since String.isEmpty() also covers the nil URL case.

WebKit Review Bot

Comment 7 2012-06-02 14:30:19 PDT

Comment on attachment 145451 [details] only use isEmpty() as Brady pointed out, since String.isEmpty() also covers the nil URL case. Clearing flags on attachment: 145451 Committed r119339: <http://trac.webkit.org/changeset/119339>

WebKit Review Bot

Comment 8 2012-06-02 14:30:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.