Bug 88131

Summary: Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
Product: WebKit Reporter: Stephen Chenney <schenney>
Component: Tools / TestsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dglazkov, jamesr, jonlee, morrita, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Stephen Chenney
Reported 2012-06-01 13:42:12 PDT
The following layout test is failing on Mac and Win debug: fast/dom/HTMLMeterElement/meter-element-crash.html This test has been flaky before, see http://trac.webkit.org/changeset/94634
Attachments
Patch (2.03 KB, patch)
2013-03-08 13:08 PST, James Robinson 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephen Chenney
Comment 1 2012-06-01 13:47:17 PDT
Committed r119277: <http://trac.webkit.org/changeset/119277>
Stephen Chenney
Comment 2 2012-06-01 13:47:40 PDT
Committed expectations update.
Alexey Proskuryakov
Comment 3 2012-06-01 13:50:02 PDT
Do you have a stack trace to post?
Ryosuke Niwa
Comment 4 2012-06-01 13:51:34 PDT
(In reply to comment #3) > Do you have a stack trace to post? Unfortunately Chromium bots delete symbols in WebKit/WebCore so we can't see anything useful. We should really change that though... it makes impossible to diagnose the problems :(
Hajime Morrita
Comment 5 2012-06-03 21:37:31 PDT
Was this crashing? If it was just failing. I could make test result more stable somehow.
James Robinson
Comment 6 2013-03-08 13:08:54 PST
Created attachment 192277 [details] Patch
James Robinson
Comment 7 2013-03-08 13:09:32 PST
I believe this patch will de-flake the test. Without this patch, locally (cr linux debug) the test fails 6-20 times when run with --repeat-each=10 --iterations=10. With this patch is passes 100/100 times.
Tony Chang
Comment 8 2013-03-08 13:12:27 PST
Comment on attachment 192277 [details] Patch Should there be a TestExpectations change to re-enable this test?
James Robinson
Comment 9 2013-03-08 13:14:24 PST
(In reply to comment #8) > (From update of attachment 192277 [details]) > Should there be a TestExpectations change to re-enable this test? I accidentally landed that part already in: http://trac.webkit.org/changeset/145259/trunk/LayoutTests/platform/chromium/TestExpectations
James Robinson
Comment 10 2013-03-08 13:22:24 PST
Committed r145263: <http://trac.webkit.org/changeset/145263>
Note You need to log in before you can comment on or make changes to this bug.