| Summary: | [Qt] Move QObject bridge related tests from tst_qwebframe to tst_qobjectbridge | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||
| Component: | New Bugs | Assignee: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | hausmann, noam | ||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Caio Marcelo de Oliveira Filho
2012-06-01 11:57:14 PDT
Created attachment 145353 [details]
Patch
Comment on attachment 145353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145353&action=review > Source/WebKit/qt/ChangeLog:149 > + (CustomType): > + (MyQObject): > + (MyQObject::MyQObject): > + (MyQObject::~MyQObject): > + (MyQObject::intProperty): > + (MyQObject::setIntProperty): > + (MyQObject::variantProperty): > + (MyQObject::setVariantProperty): > + (MyQObject::variantListProperty): > + (MyQObject::setVariantListProperty): > + (MyQObject::variantMapProperty): > + (MyQObject::setVariantMapProperty): > + (MyQObject::stringProperty): > + (MyQObject::setStringProperty): > + (MyQObject::stringListProperty): > + (MyQObject::setStringListProperty): > + (MyQObject::byteArrayProperty): > + (MyQObject::setByteArrayProperty): > + (MyQObject::brushProperty): > + (MyQObject::setBrushProperty): > + (MyQObject::hiddenProperty): > + (MyQObject::setHiddenProperty): > + (MyQObject::writeOnlyProperty): > + (MyQObject::setWriteOnlyProperty): > + (MyQObject::readOnlyProperty): > + (MyQObject::shortcut): > + (MyQObject::setShortcut): > + (MyQObject::webElementProperty): > + (MyQObject::setWebElementProperty): > + (MyQObject::propWithCustomType): > + (MyQObject::setPropWithCustomType): > + (MyQObject::objectStarProperty): > + (MyQObject::setObjectStarProperty): > + (MyQObject::qtFunctionInvoked): > + (MyQObject::qtFunctionActuals): > + (MyQObject::resetQtFunctionInvoked): > + (MyQObject::myInvokable): > + (MyQObject::myInvokableWithIntArg): > + (MyQObject::myInvokableWithLonglongArg): > + (MyQObject::myInvokableWithFloatArg): > + (MyQObject::myInvokableWithDoubleArg): > + (MyQObject::myInvokableWithStringArg): > + (MyQObject::myInvokableWithIntArgs): > + (MyQObject::myInvokableReturningInt): > + (MyQObject::myInvokableReturningLongLong): > + (MyQObject::myInvokableReturningString): > + (MyQObject::myInvokableWithEnumArg): > + (MyQObject::myInvokableWithQualifiedEnumArg): > + (MyQObject::myInvokableReturningEnum): > + (MyQObject::myInvokableReturningQualifiedEnum): > + (MyQObject::myInvokableReturningVectorOfInt): > + (MyQObject::myInvokableWithVectorOfIntArg): > + (MyQObject::myInvokableReturningQObjectStar): > + (MyQObject::myInvokableWithQObjectListArg): > + (MyQObject::myInvokableWithVariantArg): > + (MyQObject::myInvokableWithVariantMapArg): > + (MyQObject::myInvokableWithListOfIntArg): > + (MyQObject::myInvokableWithQObjectStarArg): > + (MyQObject::myInvokableWithQBrushArg): > + (MyQObject::myInvokableWithBrushStyleArg): > + (MyQObject::myInvokableWithVoidStarArg): > + (MyQObject::myInvokableWithAmbiguousArg): > + (MyQObject::myInvokableWithDefaultArgs): > + (MyQObject::myInvokableReturningRef): > + (MyQObject::myInvokableReturningConstRef): > + (MyQObject::myInvokableWithPointArg): > + (MyQObject::myInvokableWithBoolArg): > + (MyQObject::emitMySignal): > + (MyQObject::emitMySignalWithIntArg): > + (MyQObject::emitMySignal2): > + (MyQObject::emitMySignalWithDateTimeArg): > + (MyQObject::emitMySignalWithRegexArg): > + (MyQObject::mySlot): > + (MyQObject::mySlotWithIntArg): > + (MyQObject::mySlotWithDoubleArg): > + (MyQObject::mySlotWithStringArg): > + (MyQObject::myOverloadedSlot): > + (MyQObject::myProtectedSlot): > + (MyQObject::myPrivateSlot): > + (MyWebElementSlotOnlyObject): > + (MyWebElementSlotOnlyObject::doSomethingWithWebElement): > + (MyWebElementSlotOnlyObject::tagName): > + (MyOtherQObject): > + (MyOtherQObject::MyOtherQObject): > + (tst_QObjectBridge): > + (tst_QObjectBridge::evalJS): > + (tst_QObjectBridge::evalJSV): > + (tst_QObjectBridge::tst_QObjectBridge): > + (tst_QObjectBridge::init): > + (tst_QObjectBridge::cleanup): > + (tst_QObjectBridge::getSetStaticProperty): > + (tst_QObjectBridge::getSetDynamicProperty): > + (tst_QObjectBridge::getSetChildren): > + (tst_QObjectBridge::callQtInvokable): > + (tst_QObjectBridge::connectAndDisconnect): > + (tst_QObjectBridge::overrideInvokable): > + (tst_QObjectBridge::overloadedSlots): > + (MyEnumTestQObject): > + (MyEnumTestQObject::MyEnumTestQObject): > + (MyEnumTestQObject::p1): > + (MyEnumTestQObject::p2): > + (MyEnumTestQObject::p3): > + (MyEnumTestQObject::p4): > + (MyEnumTestQObject::p5): > + (MyEnumTestQObject::p6): > + (MyEnumTestQObject::mySlot): > + (MyEnumTestQObject::myOtherSlot): > + (tst_QObjectBridge::enumerate_data): > + (tst_QObjectBridge::enumerate): > + (tst_QObjectBridge::objectDeleted): > + (tst_QObjectBridge::typeConversion): > + (StringListTestObject): > + (StringListTestObject::stringList): > + (tst_QObjectBridge::arrayObjectEnumerable): > + (tst_QObjectBridge::domCycles): > + (tst_QObjectBridge::jsByteArray): > + (tst_QObjectBridge::ownership): > + (tst_QObjectBridge::nullValue): > + (TestFactory): > + (TestFactory::TestFactory): > + (TestFactory::getNewObject): > + (tst_QObjectBridge::qObjectWrapperWithSameIdentity): > + (tst_QObjectBridge::introspectQtMethods_data): > + (tst_QObjectBridge::introspectQtMethods): > + (tst_QObjectBridge::webElementSlotOnly): > + * tests/qwebframe/tst_qwebframe.cpp: > + (tst_QWebFrame): > + (tst_QWebFrame::init): > + (tst_QWebFrame::cleanup): you don't need all this in the Changelog. Committed r119267: <http://trac.webkit.org/changeset/119267> Maybe a next step would be to get rid of tests that cover functionality that is not really needed, like testing the toString behavior of specific objects. These tests many times test internal implementation details rather than expected API behavior. |