|Product:||WebKit||Reporter:||Michael Saboff <msaboff>|
|Component:||WebKit Misc.||Assignee:||Michael Saboff <msaboff>|
|Version:||528+ (Nightly build)|
Description Michael Saboff 2012-06-01 10:47:25 PDT
Comment 2 Simon Fraser (smfr) 2012-06-01 12:29:16 PDT
Comment 3 Geoffrey Garen 2012-06-01 12:37:24 PDT
Comment on attachment 145346 [details] Patch Expectation should be empty string. Does nil pass?
Comment 4 Michael Saboff 2012-06-01 13:34:11 PDT
Created attachment 145369 [details] Patch with fix (In reply to comment #3) > (From update of attachment 145346 [details]) > Expectation should be empty string. Does nil pass? I was thinking about this as I was out at lunch, realizing that the test was wrong. The test was "passing", but shouldn't. I was assuming that run-test-webkit-api built the tests before running. Therefore I wasn't testing the new code. Built and tested this patch. It works as expected.
Comment 5 Geoffrey Garen 2012-06-01 14:14:24 PDT
Comment on attachment 145369 [details] Patch with fix r=me
Comment 6 Michael Saboff 2012-06-01 14:26:29 PDT
Committed r119280: <http://trac.webkit.org/changeset/119280>