Bug 88093

Summary: WTR crashes if an external URL is passed as a parameter
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED WONTFIX    
Severity: Normal CC: allan.jensen, ap, hausmann, kbalazs, kenneth, sam, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 90623    
Bug Blocks:    
Attachments:
Description Flags
backtrace
none
Patch
none
Patch none

Zoltan Horvath
Reported 2012-06-01 07:39:50 PDT
Created attachment 145305 [details] backtrace Testcase: WebKitBuild/Debug/bin/WebKitTestRunner http://webkit.org
Attachments
backtrace (13.55 KB, application/octet-stream)
2012-06-01 07:39 PDT, Zoltan Horvath 		no flags
Details
Patch (1.36 KB, patch)
2012-06-18 10:42 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (17.21 KB, patch)
2012-07-11 05:56 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2012-06-18 10:42:38 PDT
Created attachment 148127 [details] Patch
Zoltan Herczeg
Comment 2 2012-07-05 01:02:11 PDT
Comment on attachment 148127 [details] Patch r=me
Balazs Kelemen
Comment 3 2012-07-05 04:21:57 PDT
Comment on attachment 148127 [details] Patch Clearing flags on attachment: 148127 Committed r121899: <http://trac.webkit.org/changeset/121899>
Balazs Kelemen
Comment 4 2012-07-05 04:22:04 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2012-07-05 10:55:56 PDT
Re-opened since this is blocked by 90623
Balazs Kelemen
Comment 6 2012-07-11 05:56:23 PDT
Created attachment 151693 [details] Patch
Balazs Kelemen
Comment 7 2012-08-21 04:54:04 PDT
Could anybody review this? It's there for weeks. If not I will go to the quick route and fix it in wtr to avoid touching API but still I believe the API is not perfect here.
Simon Hausmann
Comment 8 2012-08-22 03:39:54 PDT
Sam: Ping :)
Balazs Kelemen
Comment 9 2012-10-04 01:20:31 PDT
(In reply to comment #7) > Could anybody review this? It's there for weeks. If not I will go to the quick route and fix it in wtr to avoid touching API but still I believe the API is not perfect here. I realized that there is no need for this since this crash have been disappeared because external urls are now allowed in WTR/DRT. So only the API patch makes sense, if we agree that it's an improvement.
Note You need to log in before you can comment on or make changes to this bug.