Summary: | WebCore should handle text files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | WebCore Misc. | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Anders Carlsson
2006-05-09 11:03:29 PDT
Created attachment 8186 [details]
Patch
I'm not sure about whether unsupportedTextMIMETypes should be moved to WebCore...
Comment on attachment 8186 [details]
Patch
+ PassRefPtr<TextDocument> createTextDocument(FrameView* v = 0);
No need for the "v" there.
Why create separate text nodes for each piece of data written? Maybe instead we should create just one large text node.
Why create a "pre" element? Couldn't we just put the text into the body and use CSS to style as we like?
+TextDocument::TextDocument(DOMImplementation *_implementation, FrameView *v)
Please put * next to the type name. Please don't use an underscore prefix in new code.
I do think the list of unsupported text MIME types should go into WebCore.
This looks ready to go to me. r=me
We also should have some test cases of text handling. These shoudl be possible with the httpd testing mechanisms. I went ahead and committed this. I'm looking at adding test cases now. |