Bug 88060 – [Gtk] Assertions in gtk_widget_draw when acquiring pixel output

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Zan Dobersek]

Assertions are occurring in createBitmapContextFromWebView in PixelDumpSupportGtk.cpp when calling gtk_widget_draw:

gtk_widget_draw: assertion `!widget->priv->alloc_needed' failed

To avoid this gtk_widget_size_allocate should be called before gtk_widget_draw to allocate appropriate size of the container whose pixel content we're acquiring.

[Zan Dobersek]

Created attachment 145240 [details]
Patch

[Martin Robinson]

Comment on attachment 145240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145240&action=review

> Tools/DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:64
> +    GtkAllocation allocation;
> +    allocation.x = allocation.y = 0;
> +    allocation.width = width;
> +    allocation.height = height;
> +    gtk_widget_size_allocate(viewContainer, &allocation);
> +

If the allocation is wrong, won't the render tree output be wrong as well?

[Zan Dobersek]

Sigh ... this doesn't occur anymore, and I have no idea why. Resolving as invalid for now.

[Zan Dobersek]

(In reply to comment #3)
> Sigh ... this doesn't occur anymore, and I have no idea why. Resolving as invalid for now.

Spotted it again, got a proper fix as well.

[Zan Dobersek]

Created attachment 146219 [details]
Patch

[WebKit Review Bot]

Comment on attachment 146219 [details]
Patch

Clearing flags on attachment: 146219

Committed r119715: <http://trac.webkit.org/changeset/119715>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.