Bug 88058

Summary: Don't crash when re-parenting a removed HTMLMediaElement
Product: WebKit Reporter: Ami Fischman <fischman>
Component: MediaAssignee: Ami Fischman <fischman>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, fischman, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ami Fischman
Reported 2012-06-01 00:47:20 PDT
ToT crashes because loadInternal() assumes m_player is non-NULL. The patch I'm about to upload fixes the particular repro (added as a LayoutTest) but I'm not sure this is the right fix. Eric: do you know the expectation around when m_player can be assumed to be non-NULL and when it should be checked for NULLity? (can you review the file and make sure there aren't other instances of this bug?) Migrated from http://code.google.com/p/chromium/issues/detail?id=129970
Attachments
Patch (3.14 KB, patch)
2012-06-01 00:49 PDT, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Patch (3.10 KB, patch)
2012-06-04 11:34 PDT, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2012-06-04 11:42 PDT, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ami Fischman
Comment 1 2012-06-01 00:49:11 PDT
Created attachment 145231 [details] Patch
Ami Fischman
Comment 2 2012-06-04 11:34:39 PDT
Created attachment 145611 [details] Patch
Eric Carlson
Comment 3 2012-06-04 11:38:38 PDT
Comment on attachment 145611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145611&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::HTMLMediaElement::userCancelledLoad): It would be good to have a few words about why this was changed, something like "Clear the pending load flags because any pending load has been cancelled."
Ami Fischman
Comment 4 2012-06-04 11:42:27 PDT
Created attachment 145612 [details] Patch
WebKit Review Bot
Comment 5 2012-06-04 14:47:30 PDT
Comment on attachment 145612 [details] Patch Clearing flags on attachment: 145612 Committed r119428: <http://trac.webkit.org/changeset/119428>
WebKit Review Bot
Comment 6 2012-06-04 14:47:35 PDT
All reviewed patches have been landed. Closing bug.
Andy Estes
Comment 7 2012-06-12 17:17:07 PDT
<rdar://problem/11652451>
Note You need to log in before you can comment on or make changes to this bug.