| Summary: | [Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | yosin | ||||
| Component: | Forms | Assignee: | yosin | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | tkent, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 80009 | ||||||
| Attachments: |
|
||||||
This bug affects only multiplication. Created attachment 145223 [details]
Patch 1
Comment on attachment 145223 [details]
Patch 1
I made mistake for rewriting to makeUInt128.
Could you review this patch?
Thanks in advance.
Comment on attachment 145223 [details]
Patch 1
ok
Comment on attachment 145223 [details] Patch 1 Clearing flags on attachment: 145223 Committed r119205: <http://trac.webkit.org/changeset/119205> All reviewed patches have been landed. Closing bug. |
There is code cleanup failure: UInt128& UInt128::operator /=(const uint32_t divisor) { ... ORIGINAL: const uint64_t work = (uint64_t(remainder) << 32) | dividend[i]; CLEANUP: const uint64_t work = makeUInt64(remainder, dividend[i]); However, signature of makeUInt64 is static uint64_t makeUInt64(uint32_t low, uint32_t high)