Bug 88014

Summary: sandbox directive in X-WebKit-CSP header unable to create a unique origin
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, japhet, mihaip, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Adam Barth
Reported 2012-05-31 14:55:30 PDT
sandbox directive in X-WebKit-CSP header unable to create a unique origin
Attachments
Patch (8.88 KB, patch)
2012-05-31 15:02 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (14.93 KB, patch)
2012-05-31 18:13 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (14.96 KB, patch)
2012-05-31 19:22 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.96 KB, patch)
2012-05-31 23:44 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-05-31 15:02:09 PDT
Created attachment 145164 [details] Patch
Build Bot
Comment 2 2012-05-31 15:29:31 PDT
Comment on attachment 145164 [details] Patch Attachment 145164 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12868326
Adam Barth
Comment 3 2012-05-31 18:13:59 PDT
Created attachment 145185 [details] Patch
Build Bot
Comment 4 2012-05-31 18:51:59 PDT
Comment on attachment 145185 [details] Patch Attachment 145185 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12860493
Adam Barth
Comment 5 2012-05-31 19:22:39 PDT
Created attachment 145196 [details] Patch
Mihai Parparita
Comment 6 2012-05-31 20:40:39 PDT
Comment on attachment 145196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145196&action=review > Source/WebCore/ChangeLog:14 > + the SandboxOrigin bit. This patch is more complicated than you migh Typo: migh
Ryosuke Niwa
Comment 7 2012-05-31 23:01:28 PDT
Comment on attachment 145196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145196&action=review > Source/WebCore/ChangeLog:11 > + sandbox directive in CSP couldn't create a unique origin. Please add URLs of the relevant specs. > Source/WebCore/dom/Document.cpp:5036 > -void Document::initContentSecurityPolicy() > +void Document::didUpdateSecurityOrigin() Could you swap the order of these two functions so that the diff looks saner?
Adam Barth
Comment 8 2012-05-31 23:44:00 PDT
Created attachment 145218 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-06-01 02:26:45 PDT
Comment on attachment 145218 [details] Patch for landing Clearing flags on attachment: 145218 Committed r119204: <http://trac.webkit.org/changeset/119204>
WebKit Review Bot
Comment 10 2012-06-01 02:26:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.