Bug 87825

Summary: [V8] Pass Isolate to v8String() in custom bindings
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch
none
Patch
webkit.review.bot: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-05-29 23:12:20 PDT
The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to v8String() in custom bindings.
Attachments
Patch (22.05 KB, patch)
2012-05-29 23:14 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (23.07 KB, patch)
2012-05-29 23:29 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (23.80 KB, patch)
2012-05-30 18:36 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-29 23:14:47 PDT
Created attachment 144712 [details] Patch
Kentaro Hara
Comment 2 2012-05-29 23:29:12 PDT
Created attachment 144721 [details] Patch
WebKit Review Bot
Comment 3 2012-05-30 17:17:39 PDT
Comment on attachment 144721 [details] Patch Rejecting attachment 144721 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: patching file Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp Hunk #1 succeeded at 64 with fuzz 1. patching file Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12843982
Kentaro Hara
Comment 4 2012-05-30 18:36:04 PDT
Created attachment 144969 [details] patch for landing
WebKit Review Bot
Comment 5 2012-05-31 01:00:53 PDT
Comment on attachment 144969 [details] patch for landing Clearing flags on attachment: 144969 Committed r119070: <http://trac.webkit.org/changeset/119070>
Note You need to log in before you can comment on or make changes to this bug.