Bug 87818

Summary: [Shadow DOM] HTMLContentElement and HTMLShadowElement constructors should be visible.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cdumez, haraken, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63606    
Attachments:
Description Flags
Patch
none
Patch none

Description Hajime Morrita 2012-05-29 21:22:26 PDT 
Currently there is no window.HTMLContentElement nor window.HTMLShadowElement.
They should be visible.
Comment 1 Hajime Morrita 2012-05-29 23:29:26 PDT 
Created attachment 144722 [details]
Patch
Comment 2 Hajime Morrita 2012-05-29 23:42:17 PDT 
Created attachment 144725 [details]
Patch
Comment 3 Kentaro Hara 2012-05-29 23:43:56 PDT 
Comment on attachment 144725 [details]
Patch

Looks OK!
Comment 4 WebKit Review Bot 2012-05-30 00:26:55 PDT 
Comment on attachment 144725 [details]
Patch

Clearing flags on attachment: 144725

Committed r118902: <http://trac.webkit.org/changeset/118902>
Comment 5 WebKit Review Bot 2012-05-30 00:26:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2012-05-31 00:52:36 PDT 
Could you please explain why you have the following check?
shouldBe("typeof window.HTMLContentElement", "'function'");

On EFL port with JSC engine, I get an object, not a function.
Comment 7 Kentaro Hara 2012-05-31 01:05:23 PDT 
(In reply to comment #6)
> Could you please explain why you have the following check?
> shouldBe("typeof window.HTMLContentElement", "'function'");
> 
> On EFL port with JSC engine, I get an object, not a function.

morrita@: JSC returns [object] for this case. Would you rebaseline the test result?
Comment 8 Hajime Morrita 2012-05-31 16:36:26 PDT 
(In reply to comment #6)
> Could you please explain why you have the following check?
> shouldBe("typeof window.HTMLContentElement", "'function'");
> 
> On EFL port with JSC engine, I get an object, not a function.

Got it. I shouldn't have check it as a function.
It should've been checked as something defined. I'll update the test.
Thanks for the catch.

By the way, Does EFL port enable Shadow DOM?
We aren't aware any JSC port which enables Shadow DOM.
Maybe we need to fix some JSC-specific problems around shadows in that case.
Comment 9 Chris Dumez 2012-05-31 22:25:03 PDT 
(In reply to comment #8)
> (In reply to comment #6)
> > Could you please explain why you have the following check?
> > shouldBe("typeof window.HTMLContentElement", "'function'");
> > 
> > On EFL port with JSC engine, I get an object, not a function.
> 
> Got it. I shouldn't have check it as a function.
> It should've been checked as something defined. I'll update the test.
> Thanks for the catch.
> 
> By the way, Does EFL port enable Shadow DOM?
> We aren't aware any JSC port which enables Shadow DOM.
> Maybe we need to fix some JSC-specific problems around shadows in that case.

EFL port does not enable it yet but I have a patch to do so in Bug 87732.