Bug 87809 – [V8] Replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Kentaro Hara]

The objective is to pass Isolate around in V8 bindings.

In this bug we replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0. 'where isolate shouldn't be 0' is the place where isolate is retrieved directly from AccessorInfo and Arguments.

[Kentaro Hara]

Created attachment 144675 [details]
Patch

[Adam Barth]

Comment on attachment 144675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144675&action=review

> Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp:46
> +        return v8::Null();

Not passing isolate here?

[Kentaro Hara]

Comment on attachment 144675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144675&action=review

>> Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp:46
>> +        return v8::Null();
> 
> Not passing isolate here?

No. Isolate is passed here in another patch. This is a patch that passes isolate to the places where isolate cannot be 0.

[WebKit Review Bot]

Comment on attachment 144675 [details]
Patch

Clearing flags on attachment: 144675

Committed r118998: <http://trac.webkit.org/changeset/118998>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.