Bug 87809

Summary:

[V8] Replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84074

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-05-29 18:58:40 PDT

The objective is to pass Isolate around in V8 bindings.

In this bug we replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0. 'where isolate shouldn't be 0' is the place where isolate is retrieved directly from AccessorInfo and Arguments.

Comment 1 Kentaro Hara 2012-05-29 19:06:10 PDT

Created attachment 144675 [details]
Patch

Comment 2 Adam Barth 2012-05-30 09:42:37 PDT

Comment on attachment 144675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144675&action=review

> Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp:46
> +        return v8::Null();

Not passing isolate here?

Comment 3 Kentaro Hara 2012-05-30 16:46:26 PDT

Comment on attachment 144675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144675&action=review

>> Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp:46
>> +        return v8::Null();
> 
> Not passing isolate here?

No. Isolate is passed here in another patch. This is a patch that passes isolate to the places where isolate cannot be 0.

Comment 4 WebKit Review Bot 2012-05-30 17:02:58 PDT

Comment on attachment 144675 [details]
Patch

Clearing flags on attachment: 144675

Committed r118998: <http://trac.webkit.org/changeset/118998>

Comment 5 WebKit Review Bot 2012-05-30 17:03:02 PDT

All reviewed patches have been landed.  Closing bug.