Bug 87683

Summary:

Introduce a Enclosure Element for Chromium video controls

Product:

WebKit

Reporter:

Silvia Pfeiffer <silviapf>

Component:

Media

Assignee:

Silvia Pfeiffer <silviapf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, dglazkov, eric.carlson, feature-media-reviews, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84672, 87835, 88297, 88623, 88724, 88743, 88818, 89050

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-01	none
Add styling of audio shadow dowm	none
Patch for cq	none

Silvia Pfeiffer

Reported 2012-05-28 16:57:31 PDT

This is a first patch for the introduction of the new Chromium video controls, see https://bugs.webkit.org/show_bug.cgi?id=84672 . It includes the introduction of a new enclosure element that will in a separate patch allow the styling according to the new design for Chromium. Not to land separately.

Attachments
Patch (17.09 KB, patch) 2012-05-28 17:41 PDT, Silvia Pfeiffer	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (543.32 KB, application/zip) 2012-05-28 18:27 PDT, WebKit Review Bot	no flags	Details
Add styling of audio shadow dowm (17.13 KB, patch) 2012-05-28 19:56 PDT, Silvia Pfeiffer	no flags	Details Formatted Diff Diff
Patch for cq (16.89 KB, patch) 2012-06-11 17:00 PDT, Silvia Pfeiffer	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Silvia Pfeiffer

Comment 1 2012-05-28 17:41:17 PDT

Created attachment 144413 [details] Patch

WebKit Review Bot

Comment 2 2012-05-28 18:27:20 PDT

Comment on attachment 144413 [details] Patch Attachment 144413 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12849313 New failing tests: media/audio-delete-while-slider-thumb-clicked.html

WebKit Review Bot

Comment 3 2012-05-28 18:27:24 PDT

Created attachment 144417 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Silvia Pfeiffer

Comment 4 2012-05-28 19:56:56 PDT

Created attachment 144431 [details] Add styling of audio shadow dowm

Silvia Pfeiffer

Comment 5 2012-06-11 17:00:05 PDT

Created attachment 146967 [details] Patch for cq

WebKit Review Bot

Comment 6 2012-06-11 22:40:20 PDT

Comment on attachment 146967 [details] Patch for cq Clearing flags on attachment: 146967 Committed r120040: <http://trac.webkit.org/changeset/120040>

WebKit Review Bot

Comment 7 2012-06-11 22:40:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.