Summary: | [BlackBerry] http authentication challenge issue when loading favicon | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Dong <jonathan.dong.webkit> | ||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | charles.wei, japhet, joenotcharles, leo.yang, rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jonathan Dong
2012-05-28 07:43:27 PDT
Created attachment 144360 [details]
Patch
Comment on attachment 144360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144360&action=review Ok. > Source/WebCore/ChangeLog:8 > + Provided the TargetType when generating a favicon loading Provide the TargetType > Source/WebCore/ChangeLog:9 > + request. Loading favicon is triggered after the main resource Loading favicons > Source/WebCore/ChangeLog:14 > + loading, which may confuse user. the user. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:764 > + // The favicon loading is triggerred after the main resource has been loaded Typo: triggered > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:767 > + // load. If not we will receive another challenge which may confuse user. Slightly better: // and parsed, so if we cancel the authentication challenge when loading the main // resource, we should also cancel loading the favicon when it starts to // load. If not we will receive another challenge which may confuse the user. Created attachment 144418 [details]
Patch
Comment on attachment 144418 [details] Patch Clearing flags on attachment: 144418 Committed r118716: <http://trac.webkit.org/changeset/118716> All reviewed patches have been landed. Closing bug. |