Bug 87613 – [EFL][DRT] Need screen size without gui

• Component: WebKit EFL
• Status: RESOLVED LATER

[Kangil Han]

Currently EFL DRT has no screen size since it has no gui component.
Therefore, this patch added it in such circumstance.

[Kangil Han]

Created attachment 144261 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 144261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144261&action=review

> Source/WebCore/ChangeLog:9
> +        Therefore, this patch supplemented such circumstance.

I don't like this patch. I think this is correct to return 0 (or negative value) when screenRect() can't retrieve screen size. In order to pass a test case, we can't returns geometry size. If you wanna pass the test case, I think you have to modify LTC side to get screen rectangle.

[Kangil Han]

(In reply to comment #2)
> (From update of attachment 144261 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144261&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Therefore, this patch supplemented such circumstance.
> 
> I don't like this patch. I think this is correct to return 0 (or negative value) when screenRect() can't retrieve screen size. In order to pass a test case, we can't returns geometry size. If you wanna pass the test case, I think you have to modify LTC side to get screen rectangle.

We can decide policy about this case since screen object has no public standard.
But, we can't modify LTC side because other ports use it also.
If you want to decide this case as 'won't fix', then I will follow and modify test_expections.txt file.

[Gyuyoung Kim]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 144261 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=144261&action=review
> > 
> > > Source/WebCore/ChangeLog:9
> > > +        Therefore, this patch supplemented such circumstance.
> > 
> > I don't like this patch. I think this is correct to return 0 (or negative value) when screenRect() can't retrieve screen size. In order to pass a test case, we can't returns geometry size. If you wanna pass the test case, I think you have to modify LTC side to get screen rectangle.
> 
> We can decide policy about this case since screen object has no public standard.
> But, we can't modify LTC side because other ports use it also.
> If you want to decide this case as 'won't fix', then I will follow and modify test_expections.txt file.

I think we can find proper solution for this bug. I would like to move this test case to test_expections.txt until finding it.