Summary: | Some Content Security Policy console messages are missing line numbers in JSC | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephanie Lewis <slewis> | ||||||
Component: | Page Loading | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, cdumez, mkwst, rakuco, slewis, webkit-bug-importer, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar, MakingBotsRed | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Stephanie Lewis
2012-05-25 18:32:53 PDT
Checked in failing results http://trac.webkit.org/projects/webkit/changeset/118598 Created attachment 144493 [details]
Patch
The found the difference between JSC and V8 implementations of ScriptController::eventHandlerPosition(). Making JSC implementation behave as the V8 one fixes the line printing issue (because the function returns line 1 instead of line 0 in those cases). The patch does not seem to cause any regression for me.
Created attachment 144498 [details]
Patch
Update patch to remove Qt-specific expectations as well.
Comment on attachment 144498 [details]
Patch
Thanks!
Comment on attachment 144498 [details] Patch Clearing flags on attachment: 144498 Committed r118861: <http://trac.webkit.org/changeset/118861> All reviewed patches have been landed. Closing bug. |