Implied minimum size of flex items is min-content

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Tony Chang]

In new flexbox, the min-{width,height} in the flex direction should default to min-content.  This avoids overflowing flex items if we can shrink another item.  It also means we will overflow the flexbox rather than flex items.

http://dev.w3.org/csswg/css3-flexbox/#min-size-auto

[Ojan Vafai]

Created attachment 152045 [details]
Patch

[Tony Chang]

Comment on attachment 152045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152045&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:754
> +        Length min = isHorizontalFlow() ? child->style()->minWidth() : child->style()->minHeight();

Nit: childMin or maybe even childMainAxisMin

> Source/WebCore/rendering/RenderFlexibleBox.cpp:805
> +        if (childSize < minContent)
> +            return minContent;

Nit: You could either return std::max(childSize, minContent) or assign that value to childSize.

> LayoutTests/css3/flexbox/flex-item-min-size.html:41
> +    <div>Tests that flex items have default min-size to min-content in the main axis direction.</div>

It would be nice to test this for other writing modes.

[Ojan Vafai]

Committed r122508: <http://trac.webkit.org/changeset/122508>