Bug 87492

Summary: [chromium] Deprecate FileUtilities::getFileSize and getFileModifiedTime in favor of getFileMetadata
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebKit Misc.Assignee: Kinuko Yasuda <kinuko>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, vollick, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kinuko Yasuda
Reported 2012-05-25 05:12:50 PDT
[chromium] Deprecate FileUtilities::getFileSize and getFileModifiedTime in favor of a new single API getFileMetadata.
Attachments
Patch (7.39 KB, patch)
2012-05-25 10:09 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (6.97 KB, patch)
2012-05-25 10:11 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (86.77 KB, patch)
2012-05-28 18:42 PDT, vollick 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2012-05-25 10:09:29 PDT
Created attachment 144090 [details] Patch
WebKit Review Bot
Comment 2 2012-05-25 10:10:49 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kinuko Yasuda
Comment 3 2012-05-25 10:11:31 PDT
Created attachment 144092 [details] Patch
WebKit Review Bot
Comment 4 2012-05-25 18:43:33 PDT
Comment on attachment 144092 [details] Patch Clearing flags on attachment: 144092 Committed r118597: <http://trac.webkit.org/changeset/118597>
WebKit Review Bot
Comment 5 2012-05-25 18:43:37 PDT
All reviewed patches have been landed. Closing bug.
vollick
Comment 6 2012-05-28 18:42:38 PDT
Reopening to attach new patch.
vollick
Comment 7 2012-05-28 18:42:42 PDT
Created attachment 144420 [details] Patch
vollick
Comment 8 2012-05-28 18:43:44 PDT
Sorry -- this got attached to the wrong bug.
Adam Barth
Comment 9 2012-07-27 01:11:29 PDT
Comment on attachment 144420 [details] Patch Cleared review? from attachment 144420 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.