Bug 87485

Summary: [WTF] Introduce UINT64_C to MathExtras.h
Product: WebKit Reporter: yosin
Component: Web Template FrameworkAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87360    
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-05-25 03:16:11 PDT
WebSocket implementation and decimal arithmetic implementation(BUG-87360) use 64bit unsigned int literal. However, UINT64_C macro isn't available for all platforms, e.g. Qt.
Attachments
Patch 1 (3.16 KB, patch)
2012-05-25 03:25 PDT, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-05-25 03:25:27 PDT
Created attachment 144029 [details] Patch 1
Alexey Proskuryakov
Comment 2 2012-05-25 10:36:12 PDT
Should this patch be marked for review?
yosin
Comment 3 2012-05-27 18:14:03 PDT
Comment on attachment 144029 [details] Patch 1 Could you review this patch? Thanks in advance. P.S. Oops, I forgot to mark r?. :<
Kent Tamura
Comment 4 2012-05-27 18:33:02 PDT
Comment on attachment 144029 [details] Patch 1 Looks good.
WebKit Review Bot
Comment 5 2012-05-27 19:26:52 PDT
Comment on attachment 144029 [details] Patch 1 Clearing flags on attachment: 144029 Committed r118643: <http://trac.webkit.org/changeset/118643>
WebKit Review Bot
Comment 6 2012-05-27 19:26:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.