Bug 87482

Summary: Web Inspector: HeapProfiler: speed-up _calculateClassesRetainedSize and _buildAggregates
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, joepeck, keishi, loislo, oliver, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Ilya Tikhonovsky
Reported 2012-05-25 02:56:45 PDT
engine didn't inline node's classIndex method because the switch statement in it wasn't inlineable. Before: RESULT heap-snapshot: _buildAggregates= 642 ms RESULT heap-snapshot: _calculateClassesRetainedSize= 738 ms After: RESULT heap-snapshot: _buildAggregates= 335 ms RESULT heap-snapshot: _calculateClassesRetainedSize= 411 ms
Attachments
Patch (1.78 KB, patch)
2012-05-25 03:00 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-25 03:00:02 PDT
Created attachment 144020 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-05-25 03:16:12 PDT
Committed r118509: <http://trac.webkit.org/changeset/118509>
Oliver Hunt
Comment 3 2012-05-25 10:47:02 PDT
I would have argued that that's an engine bug, and not necessarily something that we should be rewriting js for.
Yury Semikhatsky
Comment 4 2012-05-28 00:57:26 PDT
(In reply to comment #3) > I would have argued that that's an engine bug, and not necessarily something that we should be rewriting js for. This is definitely an engine's flaw but given that in this case we get a noticeable performance effect without affecting the code readability and that we don't have an estimation on when the bug may be fixed in the engine I think it makes sense to fix it this way.
Note You need to log in before you can comment on or make changes to this bug.