Bug 87460

Summary: Web Inspector: Drop InspectorFileSystemInstrumentation
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: Web Inspector (Deprecated)Assignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Taiju Tsuiki
Reported 2012-05-24 21:51:57 PDT
Inspector does not need to track DOMFileSystem object now. So we can drop InspectorFileSystemInstrumentation.
Attachments
Patch (14.29 KB, patch)
2012-05-24 21:53 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (15.67 KB, patch)
2012-05-25 02:36 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Taiju Tsuiki
Comment 1 2012-05-24 21:53:30 PDT
Created attachment 143969 [details] Patch
Vsevolod Vlasov
Comment 2 2012-05-25 02:23:58 PDT
Comment on attachment 143969 [details] Patch InspectorFileSystemAgent.cpp should be removed from all build configurations, e.g. CMakeLists.txt, WebCore.gypi. See http://trac.webkit.org/changeset/101236.
Vsevolod Vlasov
Comment 3 2012-05-25 02:31:07 PDT
I meant InspectorFileSystemInstrumentation.h of course.
Taiju Tsuiki
Comment 4 2012-05-25 02:36:35 PDT
Created attachment 144016 [details] Patch
Taiju Tsuiki
Comment 5 2012-05-25 02:38:40 PDT
Thank you for pointing out! I removed it and grep through InspectorFileSystemInstrumentation in tree. I hope it's all.
Taiju Tsuiki
Comment 6 2012-05-25 03:16:20 PDT
Comment on attachment 144016 [details] Patch Thanks!
Vsevolod Vlasov
Comment 7 2012-05-25 03:23:41 PDT
Comment on attachment 144016 [details] Patch Clearing flags on attachment: 144016 Committed r118510: <http://trac.webkit.org/changeset/118510>
Vsevolod Vlasov
Comment 8 2012-05-25 03:23:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.