Bug 87424

Summary: Web Inspector: Resource object has no methods getContent and setContent
Product: WebKit Reporter: Jan Keromnes <janx>
Component: Web Inspector (Deprecated)Assignee: Jan Keromnes <janx>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, janx, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://code.google.com/chrome/extensions/devtools.inspectedWindow.html#type-Resource
Attachments:
Description Flags
Patch vsevik: review+

Jan Keromnes
Reported 2012-05-24 13:46:30 PDT
DOCUMENTATION: - http://code.google.com/chrome/extensions/devtools.panels.html#method-setOpenResourceHandler - http://code.google.com/chrome/extensions/devtools.inspectedWindow.html#type-Resource STEPS TO REPRODUCE: - Write a devtools extension using `chrome.devtools.panels.setOpenResourceHandler(function callback)`. - The handler callback `function(object Resource) {...};` receives a `Resource` object whenever the user clicks on a resource link. EVENT: User clicks on a valid resource link. EXPECTED: Handler called with `Resource` object, having attributes `type` and `url`, and methods `getContent` and `setContent`. OBSERVED: Handler called with `Resource` object, having attributes `type` and `url, but no methods.
Attachments
Patch (3.27 KB, patch)
2012-05-24 15:54 PDT, Jan Keromnes 		vsevik: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Keromnes
Comment 1 2012-05-24 13:47:49 PDT
I am writing a patch to fix this, and a test to assert correct behavior.
Jan Keromnes
Comment 2 2012-05-24 15:54:37 PDT
Created attachment 143911 [details] Patch
Andrey Kosyakov
Comment 3 2012-05-25 00:34:16 PDT
Comment on attachment 143911 [details] Patch LGTM. Thanks for fixing this and welcome to WebKit!
Andrey Kosyakov
Comment 4 2012-05-25 00:35:22 PDT
Vsevolod, could you please stamp this.
Andrey Kosyakov
Comment 5 2012-05-25 01:10:23 PDT
Committed r118492: <http://trac.webkit.org/changeset/118492>
Jan Keromnes
Comment 6 2012-05-25 01:23:11 PDT
Thanks Andrey!
Note You need to log in before you can comment on or make changes to this bug.