Bug 87390 – REGRESSION(r118352): Caused 6 editing/spelling tests crash/fail on chromium in debug. (Requested by vsevik on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/118352 broke the build:
Caused 6 editing/spelling tests crash/fail on chromium in debug. (Requested by vsevik on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 143832 [details]
ROLLOUT of r118352

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Vsevolod Vlasov]

Flakiness dashboard:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fspelling%2Fspellcheck-paste-disabled.html%2Cediting%2Fspelling%2Fspellcheck-paste.html%2Cediting%2Fspelling%2Fgrammar-paste.html%2Cediting%2Fspelling%2Fspellcheck-queue.html%2Cediting%2Fspelling%2Fspellcheck-sequencenum.html%2Cediting%2Fspelling%2Fgrammar-markers.html

Failures:
editing/spelling/grammar-markers.html - image expectations differ.

Crashes:
editing/spelling/grammar-paste.html
editing/spelling/spellcheck-paste-disabled.html
editing/spelling/spellcheck-paste.html
editing/spelling/spellcheck-queue.html
editing/spelling/spellcheck-sequencenum.html
platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html

crash log for DumpRenderTree (pid 29729):
STDOUT: <empty>
STDERR: ASSERTION FAILED: badGrammarPhraseLocation == -1
STDERR: third_party/WebKit/Source/WebCore/editing/TextCheckingHelper.cpp(495) : WTF::String WebCore::TextCheckingHelper::findFirstBadGrammar(WebCore::GrammarDetail&, int&, bool)
STDERR: 1   0x14e3d60
STDERR: 2   0x14e48b0
STDERR: 3   0x14aeabc
STDERR: 4   0x14aec38
STDERR: 5   0x14b0696
STDERR: 6   0x14b5524
STDERR: 7   0x14c2da3
STDERR: 8   0x14c1e1f
STDERR: 9   0x1651aec
STDERR: 10  0x1652c3d
STDERR: 11  0x1d13671
STDERR: 12  0xb45f74
STDERR: 13  0xb40ee8
STDERR: 14  0xb40eb9
STDERR: 15  0x558f320618e
STDERR: [29729:29729:5333145594220:ERROR:process_util_posix.cc(143)] Received signal 11
STDERR: 	base::debug::StackTrace::StackTrace() [0x875d86]
STDERR: 	base::(anonymous namespace)::StackDumpSignalHandler() [0x835e49]
STDERR: 	0x7f6ffdd1caf0
STDERR: 	WebCore::TextCheckingHelper::findFirstBadGrammar() [0x14e3d6a]
STDERR: 	WebCore::TextCheckingHelper::markAllBadGrammar() [0x14e48b0]
STDERR: 	WebCore::Editor::markMisspellingsOrBadGrammar() [0x14aeabc]
STDERR: 	WebCore::Editor::markBadGrammar() [0x14aec38]
STDERR: 	WebCore::Editor::markMisspellingsAndBadGrammar() [0x14b0696]
STDERR: 	WebCore::Editor::respondToChangedSelection() [0x14b5524]
STDERR: 	WebCore::FrameSelection::setSelection() [0x14c2da3]
STDERR: 	WebCore::FrameSelection::moveTo() [0x14c1e1f]
STDERR: 	WebCore::DOMSelection::setBaseAndExtent() [0x1651aec]
STDERR: 	WebCore::DOMSelection::selectAllChildren() [0x1652c3d]
STDERR: 	WebCore::DOMSelectionV8Internal::selectAllChildrenCallback() [0x1d13671]
STDERR: 	v8::internal::HandleApiCallHelper<>() [0xb45f74]
STDERR: 	v8::internal::Builtin_Impl_HandleApiCall() [0xb40ee8]
STDERR: 	v8::internal::Builtin_HandleApiCall() [0xb40eb9]
STDERR: 	0x558f320618e

[Vsevolod Vlasov]

Committed r118375: <http://trac.webkit.org/changeset/118375>

[Hironori Bono]

Greetings,

Sorry for theis assertion error. It seems EditorClientImpl::checkGrammarOfString() now needs to set badGrammarLocation to -1 when it is not implemented. I will update my change to fix it.

Regards,

Hironori Bono