Bug 87364

Summary:

Shadow DOM drop event tests are very flaky.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, shinyak, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Vsevolod Vlasov

Reported 2012-05-24 02:54:05 PDT

The following layout test is failing on chromium in debug. fast/dom/shadow/drop-event-for-input-in-shadow.html fast/dom/shadow/drop-event-in-shadow.html * fast/dom/shadow/drop-event-for-input-in-shadow.html: Added. * fast/dom/shadow/drop-event-in-shadow.html: Added. Probable cause: These tests were flaking since creation. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2Fshadow%2Fdrop-event-for-input-in-shadow.html%20fast%2Fdom%2Fshadow%2Fdrop-event-in-shadow.html%20

Attachments
Patch (4.76 KB, patch) 2012-07-09 19:14 PDT, Takashi Sakamoto	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Shinya Kawanaka

Comment 1 2012-05-24 03:40:21 PDT

Thanks for reporting. I'll investigate this soon

Vsevolod Vlasov

Comment 2 2012-05-24 04:10:28 PDT

Skipped in: Committed r118340: <http://trac.webkit.org/changeset/118340>

Dimitri Glazkov (Google)

Comment 3 2012-05-24 09:17:31 PDT

This is odd. The test seems fine at a glance. beginDragWithFiles is all synchronous... hmm.

Takashi Sakamoto

Comment 4 2012-07-09 19:14:59 PDT

Created attachment 151387 [details] Patch

Hajime Morrita

Comment 5 2012-07-18 19:28:42 PDT

Comment on attachment 151387 [details] Patch Let's give a shot.

WebKit Review Bot

Comment 6 2012-07-18 22:05:20 PDT

Comment on attachment 151387 [details] Patch Clearing flags on attachment: 151387 Committed r123070: <http://trac.webkit.org/changeset/123070>

WebKit Review Bot

Comment 7 2012-07-18 22:05:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.