Bug 87316 – ArgumentCoder for WebCore::Animation encodes a bool which is never decoded

• Component: WebKit2
• Status: RESOLVED FIXED

[Ralph T]

The encode function for WebCore::Animation encodes a bool as the last entry (currently L1093 in WK2/Shared/ArgumentCoders.cpp):

encoder->encodeBool(animation->isNoneAnimation());

This value is never read out in the decode function causing updates with many animations to go awry. I noticed this in my own WK port, but imagine it would break for Qt, too (though I haven't tested). The morphing power cubes demo reliably causes the issue to crop up for me.

[Ralph T]

Created attachment 143670 [details]
Decode the "isNoneAnimation" boolean value.

This fixes the issue for me. I have not tested that the issue also exists in Qt WK2, but I can't imagine why it wouldn't.

[Noam Rosenthal]

We don't use the Animation decoder anymore in Qt... are you going to submit a patch for review?

[Ralph T]

Ha, that would be why it went unnoticed then. I'd like to submit the attached patch for review -- how do I do that (long time reader, first time writer...)?

[Noam Rosenthal]

(In reply to comment #3)
> Ha, that would be why it went unnoticed then. I'd like to submit the attached patch for review -- how do I do that (long time reader, first time writer...)?

See http://www.webkit.org/coding/contributing.html
You should add a changelog, and then set the review flag to ?

[Simon Fraser (smfr)]

Mac doesn't use the Animation encoder either. Does anyone?

[Igor Trindade Oliveira]

Nobody uses Animation encoder anymore.

(In reply to comment #5)
> Mac doesn't use the Animation encoder either. Does anyone?

[Simon Fraser (smfr)]

KILL EEET!

[Ralph T]

So is everyone else running animations on a separate thread in WebProcess or using a platform-dependent mechanism for running the animation in UIProcess?

[Noam Rosenthal]

(In reply to comment #7)
> KILL EEET!
We've just disabled it recently, I'd be happy remove the code when I get a chance, unless someone else wants to :)

[Darin Adler]

I believe this was fixed a long time ago.