Summary: | WebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gregg Tavares <gman> | ||||
Component: | WebGL | Assignee: | Zhenyao Mo <zmo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kbr | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/context/context-attributes-alpha-depth-stencil-antialias.html | ||||||
Attachments: |
|
Description
Gregg Tavares
2012-05-23 14:07:33 PDT
Created attachment 144935 [details]
Patch
The test is in sync with khronos side. Please review. Comment on attachment 144935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144935&action=review Looks good. r=me > LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:170 > + shouldBe("pixel", "[127, 127, 127, 127]"); I could imagine this test being flaky. Should it have a one-pixel value tolerance? Comment on attachment 144935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144935&action=review >> LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:170 >> + shouldBe("pixel", "[127, 127, 127, 127]"); > > I could imagine this test being flaky. Should it have a one-pixel value tolerance? Agree. I'll update the khronos side and resync. Committed r119014: <http://trac.webkit.org/changeset/119014> |