Bug 87278

Summary: Move setPrivateBrowsingEnabled from layoutTestController to window.internals()
Product: WebKit Reporter: Marcelo Lira <marcelo.lira>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: cmarcelo, gustavo, menard, rakuco, tkent, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87284    
Attachments:
Description Flags
Patch
none
Patch buildbot: commit-queue-

Marcelo Lira
Reported 2012-05-23 10:19:42 PDT
Implement setPrivateBrowsingEnabled in window.internals and remove duplicated code from WebKitTestRunner and DumpRenderTree.
Attachments
Patch (41.00 KB, patch)
2012-05-23 11:47 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
Patch (43.19 KB, patch)
2012-05-23 13:07 PDT, Marcelo Lira 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Marcelo Lira
Comment 1 2012-05-23 11:47:47 PDT
Created attachment 143606 [details] Patch
Gustavo Noronha (kov)
Comment 2 2012-05-23 12:17:28 PDT
Comment on attachment 143606 [details] Patch Attachment 143606 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12772280
Caio Marcelo de Oliveira Filho
Comment 3 2012-05-23 12:25:35 PDT
Same as https://bugs.webkit.org/show_bug.cgi?id=87149#c5
Build Bot
Comment 4 2012-05-23 12:26:37 PDT
Comment on attachment 143606 [details] Patch Attachment 143606 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12774291
Marcelo Lira
Comment 5 2012-05-23 13:07:58 PDT
Created attachment 143629 [details] Patch
Build Bot
Comment 6 2012-05-23 13:40:33 PDT
Comment on attachment 143629 [details] Patch Attachment 143629 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12769313
Alexey Proskuryakov
Comment 7 2012-05-23 13:45:40 PDT
*** This bug has been marked as a duplicate of bug 85034 ***
Alexey Proskuryakov
Comment 8 2012-05-23 13:46:19 PDT
Comment on attachment 143629 [details] Patch Clearing review flag, since this has been decided wontfix in original.
Note You need to log in before you can comment on or make changes to this bug.