Bug 87258

Summary:

Several media/ LayoutTests started crashing around r118091

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Anna Cavender <annacc>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annacc, arv, haraken, imasaki, jberlin, jknotten, jsbell, steveblock, vsevik, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

87285

Bug Blocks:

Attachments:

Description	Flags
Patch	haraken: review+, webkit.review.bot: commit-queue-

Description Steve Block 2012-05-23 06:10:54 PDT

The cause is not clear, but several media tests started crashing around r118091 on a number of platforms. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=media%2Fvideo-source-none-supported.html%2Cmedia%2Ftrack%2Ftrack-prefer-captions.html%2Cmedia%2Fvideo-timeupdate-during-playback.html%2Cmedia%2Ftrack%2Ftrack-prefer-captions.html%2Cmedia%2Ftrack%2Ftrack-cues-sorted-before-dispatch.html%2Cmedia%2Ftrack%2Ftrack-cues-seeking.html

Comment 1 Steve Block 2012-05-23 06:17:14 PDT

Tests are ...

media/video-source-none-supported.html
media/track/track-prefer-captions.html
media/video-timeupdate-during-playback.html
media/track/track-cues-sorted-before-dispatch.html
media/track/track-cues-seeking.html

This could be related to Bug 73865

Comment 2 Steve Block 2012-05-23 06:23:20 PDT

Set crashing expectation for Chromium with http://trac.webkit.org/changeset/118168

Comment 3 Steve Block 2012-05-23 07:29:06 PDT

Set crashing expectation for media/video-src-invalid-remove.html in http://trac.webkit.org/changeset/118179

Comment 4 Joshua Bell 2012-05-23 09:30:20 PDT

And more crashing expectations for:

media/track/track-language-preference.html
media/track/track-load-from-element-readyState.html
media/track/track-webvtt-tc019-cue-size.html

http://trac.webkit.org/changeset/118186

Comment 5 Joshua Bell 2012-05-23 11:26:08 PDT

Added:

media/track/track-text-track-destructor-crash.html

http://trac.webkit.org/changeset/118096/ has caused widespread flaky-crashing in tests and appears to be a candidate for the crashes linked to this bug. It was rolled out in http://trac.webkit.org/changeset/118203 so if it was the cause we should see these disappear.

Comment 6 Alexey Proskuryakov 2012-05-23 13:43:54 PDT

Could this be the same as bug 87265?

Comment 7 Alexey Proskuryakov 2012-05-23 13:44:23 PDT

Sorry, I now see that Joshua said the same above.

Comment 8 Anna Cavender 2012-05-25 11:22:43 PDT

Created attachment 144106 [details]
Patch

Since r118133, r118129, r118120 and r118134 have been reverted, I'm no longer seeing these crashes.  Removing from text_expectations.txt.

Comment 9 Joshua Bell 2012-05-25 11:33:19 PDT

Looks good to me. This doesn't need a review - you can commit directly (not through the commit queue). Or ping me and I can do it.

Comment 10 Kentaro Hara 2012-05-25 15:31:51 PDT

Comment on attachment 144106 [details]
Patch

LGTM

Comment 11 WebKit Review Bot 2012-05-25 15:34:06 PDT

Comment on attachment 144106 [details]
Patch

Rejecting attachment 144106 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3021.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12793590

Comment 12 Anna Cavender 2012-05-25 15:41:54 PDT

Thanks, but I just landed by hand: http://trac.webkit.org/changeset/118575

Sorry for any confusion.