Bug 87178

Summary: Add a quirk for applications that depend on the relative ordering of progressCompleted/didFinishLoad
Product: WebKit Reporter: Tim Horton <thorton>
Component: Page LoadingAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adele, ap, beidson, japhet, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mjs: review+

Tim Horton
Reported 2012-05-22 16:07:08 PDT
This order was changed in http://trac.webkit.org/changeset/94105. <rdar://problem/11468434>
Attachments
patch (7.85 KB, patch)
2012-05-22 16:50 PDT, Tim Horton 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2012-05-22 16:50:38 PDT
Created attachment 143398 [details] patch
Maciej Stachowiak
Comment 2 2012-05-22 16:57:30 PDT
Comment on attachment 143398 [details] patch r=me
Andy Estes
Comment 3 2012-05-22 17:03:58 PDT
Comment on attachment 143398 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=143398&action=review > Source/WebCore/page/Settings.h:568 > + bool needsDidFinishLoadOrderQuirk() { return m_needsDidFinishLoadOrderQuirk; } You should const-qualify this to be consistent with other getters. > Source/WebKit/mac/WebView/WebView.mm:1361 > +- (BOOL)_needsDidFinishLoadOrderQuirk > +{ > + static BOOL needsQuirk = !WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITH_CORRECT_DID_FINISH_LOAD_ORDER) && applicationIsAppleMail(); > + return needsQuirk; > +} No reason for this to be a method. I would make it a static free function.
Tim Horton
Comment 4 2012-05-22 17:21:12 PDT
Landed with Andy's changes in http://trac.webkit.org/changeset/118086
Note You need to log in before you can comment on or make changes to this bug.