Bug 87171

Summary: REGRESSION (r98359): Video does not render on http://panic.com/dietcoda/
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.7   
Attachments:
Description Flags
Patch mjs: review+

Jer Noble
Reported 2012-05-22 14:37:30 PDT
REGRESSION (r98359): Video does not render on http://panic.com/dietcoda/
Attachments
Patch (2.23 KB, patch)
2012-05-22 14:44 PDT, Jer Noble 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-05-22 14:39:37 PDT
Behavior is very timing-specific. Only occurs on platforms that support MediaPlayerPlatformAVFoundationObjC. (i.e. Mac >= Lion).
Jer Noble
Comment 2 2012-05-22 14:39:50 PDT
Aha. We get an "AssetMetadataLoaded" notification from MediaPlayerPrivateAVFoundationObjC and call metadataLoaded(), which calls prepareForRendering(). However, prepareForRendering() checks the m_readyState to see if it's at least HaveMetadata, and it's not, so the layer is never created. m_readyState is then updated to HaveMetadata when the notification calls updateStates().
Jer Noble
Comment 3 2012-05-22 14:40:11 PDT
<rdar://problem/11497837>
Jer Noble
Comment 4 2012-05-22 14:44:54 PDT
Created attachment 143368 [details] Patch
Maciej Stachowiak
Comment 5 2012-05-22 16:53:01 PDT
Comment on attachment 143368 [details] Patch r=me
Jer Noble
Comment 6 2012-05-22 17:23:08 PDT
Committed r118087: <http://trac.webkit.org/changeset/118087>
Note You need to log in before you can comment on or make changes to this bug.