Bug 87161

Summary: DFG CSE should do redundant store elimination
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
the patch
oliver: review+
the patch oliver: review+

Filip Pizlo
Reported 2012-05-22 13:36:20 PDT
Patch forthcoming.
Attachments
work in progress (18.34 KB, patch)
2012-05-22 13:38 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (29.64 KB, patch)
2012-05-22 15:56 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
the patch (35.49 KB, patch)
2012-05-22 23:12 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-05-22 13:38:19 PDT
Created attachment 143353 [details] work in progress
Filip Pizlo
Comment 2 2012-05-22 15:56:21 PDT
Created attachment 143387 [details] the patch
Filip Pizlo
Comment 3 2012-05-22 20:19:24 PDT
Landed in http://trac.webkit.org/changeset/118108
Filip Pizlo
Comment 4 2012-05-22 22:58:50 PDT
Reopening because the first cut turns out to be wrong.
Filip Pizlo
Comment 5 2012-05-22 23:07:17 PDT
Rolled out in http://trac.webkit.org/changeset/118126
Filip Pizlo
Comment 6 2012-05-22 23:12:35 PDT
Created attachment 143470 [details] the patch Includes two fixes for handling implicit loads of local variables: GetScopeChain reads the activation register. Hence, removing a SetLocal to the activation register that is live at the GetScopeChain is wrong. There are other cases of implicit loads of locals, but they are already marked as either exiting or clobbering, so they are already handled correctly.
Oliver Hunt
Comment 7 2012-05-22 23:42:23 PDT
Comment on attachment 143470 [details] the patch rs=me on some tests for "redundant" store elim on captured variables
Filip Pizlo
Comment 8 2012-05-23 00:30:50 PDT
Landed in http://trac.webkit.org/changeset/118138 Still trying to figure out reduced tests. Leaving open until I figure it out, or give up.
Filip Pizlo
Comment 9 2012-05-25 15:47:08 PDT
Merged in http://trac.webkit.org/changeset/118579
Note You need to log in before you can comment on or make changes to this bug.