Bug 87142

Summary:

REGRESSION(r117613): Dromaeo/jslib-style-prototype regressed by 20%

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

CSS

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling, koivisto, menard, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Tony Chang

Reported 2012-05-22 10:12:17 PDT

Probably because I moved CSSPropertyDisplay from the fast table to the slow table.

Attachments
Patch (6.71 KB, patch) 2012-05-22 11:35 PDT, Tony Chang	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2012-05-22 11:32:38 PDT

http://webkit-perf.appspot.com/graph.html#tests=[[39020,2001,3001]]&sel=1337320768437.756,1337421568437.756,3097.560975609756,5841.463414634147&displayrange=7&datatype=running

Tony Chang

Comment 2 2012-05-22 11:35:54 PDT

Created attachment 143334 [details] Patch

Tony Chang

Comment 3 2012-05-22 11:37:13 PDT

This seemed to fix the regression on my machine, but I see a 5% swing in the test results locally, so it's hard to be certain (the graph shows similar variance).

WebKit Review Bot

Comment 4 2012-05-22 13:49:21 PDT

Comment on attachment 143334 [details] Patch Clearing flags on attachment: 143334 Committed r118044: <http://trac.webkit.org/changeset/118044>

WebKit Review Bot

Comment 5 2012-05-22 13:49:26 PDT

All reviewed patches have been landed. Closing bug.

Ryosuke Niwa

Comment 6 2012-05-23 00:39:45 PDT

It does appear that this patch fixed the regression: http://webkit-perf.appspot.com/graph.html#tests=[[39020,2001,3001]]&sel=1337739099058.127,1337757519362.6953,3278.688524590164,6426.229508196721&displayrange=7&datatype=running

Alexey Proskuryakov

Comment 7 2012-12-18 09:49:55 PST

This caused bug 105275.

Note You need to log in before you can comment on or make changes to this bug.