Bug 87093

Summary: [EFL] Style issue due to tests duplicated in Skipped in test_expectations.txt
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-05-22 00:46:04 PDT
The style script is complaining about the following tests: LayoutTests/platform/efl/test_expectations.txt:6: fast/dom/shadow/content-element-api.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:7: fast/dom/shadow/content-element-outside-shadow.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:38: editing/pasteboard/drag-files-to-editable-element.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:42: fast/events/drop-handler-should-not-stop-navigate.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:43: fast/events/drop-with-file-paths.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:44: fast/files/file-reader-directory-crash.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:119: fast/events/show-modal-dialog-onblur-onfocus.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:120: fast/harness/show-modal-dialog.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:286: fast/dom/title-directionality.html is also in a Skipped file. [test/expectations] [5]
Attachments
Patch (3.52 KB, patch)
2012-05-22 00:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-05-22 00:47:45 PDT
Created attachment 143216 [details] Patch Could someone please cq+ ?
Grzegorz Czajkowski
Comment 2 2012-05-22 00:54:40 PDT
Comment on attachment 143216 [details] Patch LGTM. Thanks.
WebKit Review Bot
Comment 3 2012-05-22 01:35:34 PDT
Comment on attachment 143216 [details] Patch Clearing flags on attachment: 143216 Committed r117932: <http://trac.webkit.org/changeset/117932>
WebKit Review Bot
Comment 4 2012-05-22 01:35:39 PDT
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 5 2012-05-22 03:55:55 PDT
Two new failures after this patch: fast/events/drop-handler-should-not-stop-navigate.html = TEXT fast/files/file-reader-directory-crash.html = TEXT
Chris Dumez
Comment 6 2012-05-22 04:04:32 PDT
Will address the issue in Bug 87115.
Note You need to log in before you can comment on or make changes to this bug.