Bug 87076

Summary:

DOM Attr objects pointing to "style" attribute should force reification when read.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

DOM

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2012-05-21 19:58:34 PDT

DOM Attr needs to respect the lazy serialization strategy of the style attribute.

Comment 1 Andreas Kling 2012-05-22 00:30:23 PDT

Created attachment 143212 [details]
Patch

Comment 2 Antti Koivisto 2012-05-22 01:14:19 PDT

Comment on attachment 143212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143212&action=review

r=me

> Source/WebCore/dom/Attr.cpp:206
>      if (m_element)
> -        return m_element->getAttributeItem(qualifiedName())->value();
> +        return m_element->getAttribute(qualifiedName());

Could use a comment.

Comment 3 Andreas Kling 2012-05-22 05:05:44 PDT

Comment on attachment 143212 [details]
Patch

Clearing flags on attachment: 143212

Committed r117956: <http://trac.webkit.org/changeset/117956>

Comment 4 Andreas Kling 2012-05-22 05:05:52 PDT

All reviewed patches have been landed.  Closing bug.