Bug 87050 – REGRESSION (r105513): CSS max-width is not applied to SVG element

• Component: SVG
• Status: RESOLVED FIXED

Created attachment 143108 [details]
Test case

<rdar://problem/11331943>

To reproduce, open the test case. The square should be 100 pixels wide, but instead it is 400 pixels wide. This seems to have been caused by <http://trac.webkit.org/r105513>

Firefox and Opera match WebKit’s pre-r105513 behavior.

The same is true for max-height.

Created attachment 143379 [details]
Check if max-width and max-height were specified in RenderSVGRoot::computeReplacedLogical{Width,Height}

Fixed in <http://trac.webkit.org/r118074>.

[Nikolas Zimmermann]

Thanks for the quick fix Dan!
Why was the call to hasReplacedLogicalHeight() removed?

bool RenderReplaced::hasReplacedLogicalHeight() const
{
    if (style()->logicalHeight().isAuto())
        return false;

    if (style()->logicalHeight().isSpecified()) {
        if (hasAutoHeightOrContainingBlockWithAutoHeight(this))
            return false;
        return true;
    }

    return false;
}

It contains extra logic, for auto height containing blocks. Is that not needed or wrong for RenderSVGRoot? It's been a while since I looked at this.
CC'ing Florin, who added this IIRC.

[Florin Malita]

(In reply to comment #5)
> Thanks for the quick fix Dan!
> Why was the call to hasReplacedLogicalHeight() removed?
> [...]
> CC'ing Florin, who added this IIRC.

I'm not familiar with it either - you're probably recalling me adding hasRelativeLogicalHeight, not hasReplacedLogicalHeight :)