| Summary: | [Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hugo Parente Lima <hugo.lima> | ||||||||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | dglazkov, menard, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Hugo Parente Lima
2012-05-21 13:57:31 PDT
Created attachment 143093 [details]
Patch
Comment on attachment 143093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143093&action=review The #ifdef cleanup needs to go in a separate patch. He has nothing to do with the main content of the patch (especially that it is in a different file). > Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:242 > + QEvent* pressEvent = new QKeyEvent(QEvent::KeyPress, code, modifiers, keyText); nitpick: Why modifying QKeyEvent to QEvent? Keep it specialized. (In reply to comment #2) > (From update of attachment 143093 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143093&action=review > > The #ifdef cleanup needs to go in a separate patch. He has nothing to do with the main content of the patch (especially that it is in a different file). > > > Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:242 > > + QEvent* pressEvent = new QKeyEvent(QEvent::KeyPress, code, modifiers, keyText); > > nitpick: Why modifying QKeyEvent to QEvent? Keep it specialized. Because it don't need to be specialized besides it's used only in the next line =], but ok, I can change that. Created attachment 143094 [details]
Patch
Created attachment 143099 [details]
Patch
Comment on attachment 143099 [details] Patch Attachment 143099 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12739636 New failing tests: svg/animations/svgnumberoptionalnumber-animation-2.html Created attachment 143152 [details]
Archive of layout-test-results from ec2-cr-linux-04
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 143099 [details]
Patch
cq+ again as this parch only modify Qt bits.
Comment on attachment 143099 [details] Patch Rejecting attachment 143099 [details] from commit-queue. New failing tests: svg/W3C-SVG-1.1/types-basicDOM-01-b.svg Full output: http://queues.webkit.org/results/12742433 Created attachment 143177 [details]
Archive of layout-test-results from ec2-cq-03
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 143099 [details] Patch Clearing flags on attachment: 143099 Committed r117964: <http://trac.webkit.org/changeset/117964> All reviewed patches have been landed. Closing bug. |