Summary: | Incorporate new tex-image-and-sub-image-2d-with-video*.html tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, feature-media-reviews, fischman, kbr, webkit.review.bot, zmo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 86877 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Kenneth Russell
2012-05-21 13:41:28 PDT
Chromium-side fix is in the CQ: https://chromiumcodereview.appspot.com/10332275/ With that fix in place, the refactored tests still fail to run properly. The failure mode is strange; it looks like the presence of the video tag on the page is causing the onload handler to fail to run before the LayoutTestController decides whether it should exit early or wait until done. Will put up a patch for these tests after fixing Bug 86877 so we can investigate whether there is a bug in event dispatching related to the video tag. There was no bug in the video tag. The test was just pointing to nonexistent resources so the "playing" event was never dispatched. Integrating the new tests now. Actually, I take that back. There is something weird going on. These tests were calling layoutTestController.waitUntilDone() inside the onload handler, but when that is done, they intermittently exit early. Instead it's necessary to call waitUntilDone() in script that's executed while the page is being loaded. I think that is a bug and will file it separately. Bug 87448 filed about race condition with video tag. Created attachment 143947 [details]
Patch
Comment on attachment 143947 [details]
Patch
Looks good.
Comment on attachment 143947 [details] Patch Clearing flags on attachment: 143947 Committed r118565: <http://trac.webkit.org/changeset/118565> All reviewed patches have been landed. Closing bug. |