Bug 87035

Summary: !HAVE(ACCESSIBILITY) should be able to build without linking in any code from WebCore/accessibility
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, eric, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch
none
Patch
none
Patch none

Description Adam Barth 2012-05-21 11:36:24 PDT 
!HAVE(ACCESSIBILITY) should be able to build without linking in any code from WebCore/accessibility
Comment 1 Eric Seidel (no email) 2012-05-21 11:39:44 PDT 
Presumably this is a chromium-only issue? :)
Comment 2 Adam Barth 2012-05-21 11:40:05 PDT 
Created attachment 143067 [details]
Patch
Comment 3 chris fleizach 2012-05-21 11:41:42 PDT 
Comment on attachment 143067 [details]
Patch

looks ok
Comment 4 Early Warning System Bot 2012-05-21 11:54:02 PDT 
Comment on attachment 143067 [details]
Patch

Attachment 143067 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12731700
Comment 5 Adam Barth 2012-05-21 11:54:38 PDT 
> Presumably this is a chromium-only issue? :)

It's likely to reduce the binary size on other ports that use !HAVE(ACCESSIBILITY) too.
Comment 6 Early Warning System Bot 2012-05-21 11:57:54 PDT 
Comment on attachment 143067 [details]
Patch

Attachment 143067 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12736641
Comment 7 Adam Barth 2012-05-21 15:08:13 PDT 
Created attachment 143110 [details]
Patch for landing
Comment 8 Adam Barth 2012-05-21 15:08:56 PDT 
This patch should remove the duplicate symbols.
Comment 9 Early Warning System Bot 2012-05-21 15:43:51 PDT 
Comment on attachment 143110 [details]
Patch for landing

Attachment 143110 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12747180
Comment 10 Early Warning System Bot 2012-05-21 15:49:55 PDT 
Comment on attachment 143110 [details]
Patch for landing

Attachment 143110 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12740569
Comment 11 Adam Barth 2012-05-21 15:50:40 PDT 
Comment on attachment 143110 [details]
Patch for landing

Too tight.  /me tries again.
Comment 12 Adam Barth 2012-05-21 15:57:02 PDT 
Created attachment 143123 [details]
Patch
Comment 13 Early Warning System Bot 2012-05-21 16:05:12 PDT 
Comment on attachment 143123 [details]
Patch

Attachment 143123 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12738599
Comment 14 Adam Barth 2012-05-21 16:11:06 PDT 
Created attachment 143125 [details]
Patch
Comment 15 Early Warning System Bot 2012-05-21 16:17:42 PDT 
Comment on attachment 143125 [details]
Patch

Attachment 143125 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12747194
Comment 16 Early Warning System Bot 2012-05-21 16:18:52 PDT 
Comment on attachment 143125 [details]
Patch

Attachment 143125 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12742372
Comment 17 Adam Barth 2012-05-21 16:23:06 PDT 
Created attachment 143126 [details]
Patch
Comment 18 WebKit Review Bot 2012-05-21 22:46:01 PDT 
Comment on attachment 143126 [details]
Patch

Clearing flags on attachment: 143126

Committed r117907: <http://trac.webkit.org/changeset/117907>
Comment 19 WebKit Review Bot 2012-05-21 22:46:09 PDT 
All reviewed patches have been landed.  Closing bug.