Bug 87032

Summary: Restore WebGL's framebuffer binding after DrawingBuffer's prepareBackBuffer()
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, gman, jamesr, kbr, twiz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jamesr: review+

Zhenyao Mo
Reported 2012-05-21 11:19:42 PDT
This is regressed again. Last time I added restoreFramebufferBinding(), now this function is no longer called anywhere, and apparently that caused the binding to be lost.
Attachments
Patch (1.25 KB, patch)
2012-05-21 11:39 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2012-05-21 13:04 PDT, Zhenyao Mo 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2012-05-21 11:39:24 PDT
Created attachment 143066 [details] Patch
Zhenyao Mo
Comment 2 2012-05-21 11:40:25 PDT
Please review. Once this lands and webkit rolls, I'll make sure to enable related webgl conformance tests in chromium immediately.
James Robinson
Comment 3 2012-05-21 11:48:08 PDT
Comment on attachment 143066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143066&action=review > Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp:138 > if (multisample()) > bind(); > + > + restoreFramebufferBinding(); Something here is clearly wrong. line 136 is binding m_multisampleFBO ? m_multisampleFBO : m_fbo. Line 138 is binding m_framebufferBinding. We should make up our mind and just bind one.
Zhenyao Mo
Comment 4 2012-05-21 13:04:56 PDT
Created attachment 143083 [details] Patch
Zhenyao Mo
Comment 5 2012-05-21 13:05:18 PDT
Revised, please have another look.
James Robinson
Comment 6 2012-05-21 13:16:37 PDT
Comment on attachment 143083 [details] Patch Thanks, that does look better.
Kenneth Russell
Comment 7 2012-05-21 13:49:33 PDT
Comment on attachment 143083 [details] Patch Looks fine to me too.
Zhenyao Mo
Comment 8 2012-05-21 14:00:26 PDT
Committed r117814: <http://trac.webkit.org/changeset/117814>
Note You need to log in before you can comment on or make changes to this bug.