Bug 86965

Summary:

[Chromium] Print layout test result on buildbot

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

Tools / Tests

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, eric, jochen, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Gyuyoung Kim

Reported 2012-05-20 08:19:08 PDT

Chrome build bot doesn't print layout test result unlike other ports. If chrome buildbot prints result of layout test, it will help to check layout test status for chromium port.

Attachments
Patch (1.48 KB, patch) 2012-05-20 08:22 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2012-05-20 08:22:45 PDT

Created attachment 142904 [details] Patch

jochen

Comment 2 2012-05-20 11:00:08 PDT

The user chrome-bot is correct Adding Adam and Eric as they run our bots

Eric Seidel (no email)

Comment 3 2012-05-20 11:07:31 PDT

I thought we had moved all the buildbots to modern NRWT-aware configurations? Lame that we're depending on this wrapper hack.

Eric Seidel (no email)

Comment 4 2012-05-20 11:10:09 PDT

It looks like we still have a separate NRWT rule: http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L405 but the RWT rule is generic: http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L279

jochen

Comment 5 2012-05-20 11:12:29 PDT

(In reply to comment #4) > It looks like we still have a separate NRWT rule: > http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L405 > > but the RWT rule is generic: > http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L279 The bots definitely run RWT: http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29/builds/32799/steps/layout-test/logs/stdio

Eric Seidel (no email)

Comment 6 2012-05-20 11:44:09 PDT

Comment on attachment 142904 [details] Patch Some of this confusion is all tied up in the fact that we have only one port which still use ORWT (AppleWin). This is not the "Right" fix. But this is totally fine. THanks.

WebKit Review Bot

Comment 7 2012-05-20 12:09:45 PDT

Comment on attachment 142904 [details] Patch Clearing flags on attachment: 142904 Committed r117708: <http://trac.webkit.org/changeset/117708>

WebKit Review Bot

Comment 8 2012-05-20 12:09:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.