| Summary: | [Chromium] Print layout test result on buildbot | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Component: | Tools / Tests | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, eric, jochen, rniwa, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Gyuyoung Kim
2012-05-20 08:19:08 PDT
Created attachment 142904 [details]
Patch
The user chrome-bot is correct Adding Adam and Eric as they run our bots I thought we had moved all the buildbots to modern NRWT-aware configurations? Lame that we're depending on this wrapper hack. It looks like we still have a separate NRWT rule: http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L405 but the RWT rule is generic: http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L279 (In reply to comment #4) > It looks like we still have a separate NRWT rule: > http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L405 > > but the RWT rule is generic: > http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L279 The bots definitely run RWT: http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29/builds/32799/steps/layout-test/logs/stdio Comment on attachment 142904 [details]
Patch
Some of this confusion is all tied up in the fact that we have only one port which still use ORWT (AppleWin).
This is not the "Right" fix. But this is totally fine. THanks.
Comment on attachment 142904 [details] Patch Clearing flags on attachment: 142904 Committed r117708: <http://trac.webkit.org/changeset/117708> All reviewed patches have been landed. Closing bug. |