Bug 86964

Summary: Unsupported commands should have queryCommandValue() = "", not false
Product: WebKit Reporter: Aryeh Gregor <ayg>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, joethomas, ojan, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
ProposedPatch
rniwa: review+, rniwa: commit-queue-
Patch-Updated none

Aryeh Gregor
Reported 2012-05-20 07:58:06 PDT
Test-case: data:text/html,<!doctype html> <script> var val = document.queryCommandValue("quasit"); alert(typeof val + ' "' + val + '"'); </script> Chrome 20 dev alerts 'boolean "false"'. This means queryCommandValue() is returning a boolean, when it's specced to always return a string. Gecko now returns the empty string, per spec <https://bugzilla.mozilla.org/show_bug.cgi?id=742240#c18>. IE throws, which we decided in bug 83993 was not acceptable. WebKit should return the empty string here. This probably doesn't have big compat impact, because false == "" in JavaScript.
Attachments
ProposedPatch (5.86 KB, patch)
2012-05-20 15:53 PDT, Joe Thomas 		rniwa: review+
rniwa: commit-queue-
DetailsFormatted DiffDiff
Patch-Updated (6.04 KB, patch)
2012-05-20 17:22 PDT, Joe Thomas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joe Thomas
Comment 1 2012-05-20 14:25:07 PDT
I will create a patch for this
Joe Thomas
Comment 2 2012-05-20 15:53:39 PDT
Created attachment 142923 [details] ProposedPatch
Ryosuke Niwa
Comment 3 2012-05-20 17:01:55 PDT
Comment on attachment 142923 [details] ProposedPatch View in context: https://bugs.webkit.org/attachment.cgi?id=142923&action=review > LayoutTests/editing/execCommand/use-css.html:51 > testFailed("queryCommandValue('useCSS') should return boolean false"); Please update this comment as well.
Joe Thomas
Comment 4 2012-05-20 17:22:53 PDT
Created attachment 142928 [details] Patch-Updated
Joe Thomas
Comment 5 2012-05-20 17:23:44 PDT
(In reply to comment #3) > (From update of attachment 142923 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142923&action=review > > > LayoutTests/editing/execCommand/use-css.html:51 > > testFailed("queryCommandValue('useCSS') should return boolean false"); > > Please update this comment as well. Done. I missed it.
WebKit Review Bot
Comment 6 2012-05-20 18:46:33 PDT
Comment on attachment 142928 [details] Patch-Updated Clearing flags on attachment: 142928 Committed r117721: <http://trac.webkit.org/changeset/117721>
WebKit Review Bot
Comment 7 2012-05-20 18:46:38 PDT
All reviewed patches have been landed. Closing bug.
Joe Thomas
Comment 8 2012-05-20 20:16:49 PDT
Thanks for the review :)
Note You need to log in before you can comment on or make changes to this bug.