Bug 86950 – Shrink FontDescription object size

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Rob Buis]

Through bit packing we can shrink the size of this class. Note that this means Font, StyleInheritedData and RenderSVGInlineText shrink too.

[Rob Buis]

Created attachment 142884 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 142884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142884&action=review

> Source/WebCore/platform/graphics/FontDescription.cpp:-37
> -    void* settings;

This is weird - there is no member names settings, is there?

[Rob Buis]

Hi Alexey,

Thanks for the r+! I'll land later tonight.

(In reply to comment #2)
> (From update of attachment 142884 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142884&action=review
> 
> > Source/WebCore/platform/graphics/FontDescription.cpp:-37
> > -    void* settings;
> 
> This is weird - there is no member names settings, is there?

Yes, that had me puzzled for a while too. Maybe m_featureSettings was once called settings? After my patch we get rid of exactly this amount of bytes, and it should make SameSizeAsFontDescription actually accurate this time.

[Rob Buis]

Committed r117971: <http://trac.webkit.org/changeset/117971>