Bug 86940

Summary:

[EFL] Massive rebaselining needed after r117672

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit EFL

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, leandro, lucas.de.marchi, naginenis, rakuco, rniwa, webkit.review.bot, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2012-05-19 03:59:57 PDT

A massive rebaselining is needed after r117672 (Bug 86784).

In many tests, contents in input element are shifted to the start (left in LTR and right in RTL) by 1px, and widths of input elements are shrunk by 2px.

Comment 1 Chris Dumez 2012-05-19 04:52:48 PDT

Created attachment 142861 [details]
Patch

Could someone please double check and cq+ ?

Comment 2 Zan Dobersek 2012-05-19 06:47:03 PDT

(In reply to comment #1)
> Created an attachment (id=142861) [details]
> Patch
> 
> Could someone please double check and cq+ ?

Looks good.

Comment 3 Leandro Pereira 2012-05-19 06:48:23 PDT

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=142861) [details] [details]
> > Patch
> > 
> > Could someone please double check and cq+ ?
> 
> Looks good.
>

Yes, LGTM.

Comment 4 WebKit Review Bot 2012-05-19 07:00:33 PDT

Comment on attachment 142861 [details]
Patch

Clearing flags on attachment: 142861

Committed r117690: <http://trac.webkit.org/changeset/117690>

Comment 5 WebKit Review Bot 2012-05-19 07:00:39 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Chris Dumez 2012-05-19 07:32:47 PDT

Apparently my patch was incomplete and the following tests still need rebaseline:
  css3/selectors3/html/css3-modsel-23.html = TEXT
  css3/selectors3/html/css3-modsel-24.html = TEXT
  css3/selectors3/html/css3-modsel-68.html = TEXT
  css3/selectors3/html/css3-modsel-69.html = TEXT
  css3/selectors3/xhtml/css3-modsel-23.xml = TEXT
  css3/selectors3/xhtml/css3-modsel-24.xml = TEXT
  css3/selectors3/xhtml/css3-modsel-68.xml = TEXT
  css3/selectors3/xhtml/css3-modsel-69.xml = TEXT
  css3/selectors3/xml/css3-modsel-23.xml = TEXT
  css3/selectors3/xml/css3-modsel-24.xml = TEXT
  css3/selectors3/xml/css3-modsel-68.xml = TEXT
  css3/selectors3/xml/css3-modsel-69.xml = TEXT
  fast/forms/input-appearance-bkcolor.html = TEXT
  fast/forms/textfield-outline.html = TEXT

I'll look into it later.