Bug 8690

Summary:	Contributing code doesn't mention what to do with new files
Product:	WebKit	Reporter:	Matt Gough <matt>
Component:	WebKit Website	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mrowe
Priority:	P2
Version:	420+
Hardware:	Mac
OS:	OS X 10.4
URL:	http://webkit.org/coding/contributing.html

Matt Gough

Reported 2006-05-02 03:20:48 PDT

This page doesn't mention what to do with new files that are added to the project (e.g test cases) Apparently you should do 'svn add' on them so that the get noticed by svn-create-patch. Also, although it mentions 'Make sure that your patch includes a ChangeLog entry' it doesn't mention using 'prepare-ChangeLog'.

Attachments
Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2007-03-19 03:07:56 PDT

prepare-ChangeLog is now mentioned. The 'svn add' issue still stands.

Mark Rowe (bdash)

Comment 2 2007-03-20 18:02:06 PDT

Fixed by r20354.

Note You need to log in before you can comment on or make changes to this bug.