Bug 86838

Summary: [EFL][DRT] Key modifier bit flags have enum type.
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85369    
Attachments:
Description Flags
patch
none
patch v2 (review comments are met) none

Description Mikhail Pozdnyakov 2012-05-18 03:22:39 PDT 
Key modifier bit flags have enum type. It causes problems as a key can have several modifiers at the same time and the union of modifiers (i.e. EvasKeyModifierControl | EvasKeyModifierShift) will be out of EvasKeyModifier enum, so refactoring is needed here.
Comment 1 Mikhail Pozdnyakov 2012-05-18 04:47:45 PDT 
Created attachment 142686 [details]
patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-18 08:00:19 PDT 
Comment on attachment 142686 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142686&action=review

I'd rather change the type of KeyEventInfo::modifiers to unsigned (as is already done in places such as PlatformEvent.h in WebCore) and keep the enum an enum.

> Tools/ChangeLog:8
> +        Refactoring. EvasKeyModifier is unsigned int.

Your explanation in the original bug comment is much more helpful, please consider adding it here.
Comment 3 Mikhail Pozdnyakov 2012-05-21 07:01:49 PDT 
Created attachment 143025 [details]
patch v2 (review comments are met)
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-21 08:21:29 PDT 
Comment on attachment 143025 [details]
patch v2 (review comments are met)

Looks good to me.
Comment 5 WebKit Review Bot 2012-05-22 11:11:13 PDT 
Comment on attachment 143025 [details]
patch v2 (review comments are met)

Clearing flags on attachment: 143025

Committed r118006: <http://trac.webkit.org/changeset/118006>
Comment 6 WebKit Review Bot 2012-05-22 11:11:18 PDT 
All reviewed patches have been landed.  Closing bug.