Bug 86836

Summary: [EFL] Text input events are emitted for nodes that do not allow editing.
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85369    
Attachments:
Description Flags
Fix.
none
patch v2 (added more info to changelog) none

Description Mikhail Pozdnyakov 2012-05-18 03:12:27 PDT
Text input events are emitted for nodes that do not allow editing.
Comment 1 Mikhail Pozdnyakov 2012-05-18 03:40:43 PDT
Created attachment 142679 [details]
Fix.
Comment 2 Gyuyoung Kim 2012-05-18 03:58:41 PDT
Comment on attachment 142679 [details]
Fix.

Looks good to me.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-05-18 05:50:51 PDT
Do we have a test for this?
Comment 4 Mikhail Pozdnyakov 2012-05-18 05:51:53 PDT
(In reply to comment #3)
> Do we have a test for this?

fast/events/key-events-in-input-button.html
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-05-18 05:53:15 PDT
Can you please mention that in the ChangeLog?
Comment 6 Mikhail Pozdnyakov 2012-05-18 05:59:42 PDT
Created attachment 142697 [details]
patch v2 (added more info to changelog)
Comment 7 Mikhail Pozdnyakov 2012-05-18 06:00:07 PDT
(In reply to comment #5)
> Can you please mention that in the ChangeLog?

sure
Comment 8 Raphael Kubo da Costa (:rakuco) 2012-05-18 06:00:32 PDT
Comment on attachment 142697 [details]
patch v2 (added more info to changelog)

Looks good, thank you.
Comment 9 WebKit Review Bot 2012-05-18 06:54:21 PDT
Comment on attachment 142697 [details]
patch v2 (added more info to changelog)

Clearing flags on attachment: 142697

Committed r117584: <http://trac.webkit.org/changeset/117584>
Comment 10 WebKit Review Bot 2012-05-18 06:54:27 PDT
All reviewed patches have been landed.  Closing bug.