Bug 86805
| Summary: | Web Inspector: CSS profiles don't include time spent in element.webkitMatchesSelector | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Web Inspector | Assignee: | Alexander Pavlov (apavlov) <apavlov> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | apavlov, burg, bweinstein, caseq, graouts, joepeck, keishi, loislo, me, paulirish, pfeldman, pmuellr, rik, timothy, webkit-bug-importer, yurys |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Adam Roben (:aroben)
It looks like CSS profile data is only collected in WebCore::StyleResolver member functions. But StyleResolver isn't used for element.webkitMatchesSelector. For that we need to instrument WebCore::Element::webkitMatchesSelector (surprise!).
It would be great to include webkitMatchesSelector time in CSS profiles. Bonus points if it's somehow separable from other kinds of time like style recalcs.
See also bug 86804.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brian Burg
Needs test case, not sure if still relevant. We do show duration in "Style Recalculated" timeline records.
Radar WebKit Bug Importer
<rdar://problem/19107167>
Brian Burg
Doesn't seem to matter any more.