Bug 86767

Summary: remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, donggwan.kim, eric, fishd, hyatt, jamesr, jchaffraix, macpherson, menard, ojan, rakuco, rniwa, tkent, tkent+wkapi, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ec2-cr-linux-03
none
Patch for landing none

Tony Chang
Reported 2012-05-17 12:23:06 PDT
remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
Attachments
Patch (54.04 KB, patch)
2012-05-17 12:32 PDT, Tony Chang
no flags
Patch (54.07 KB, patch)
2012-05-17 12:34 PDT, Tony Chang
no flags
Patch (71.10 KB, patch)
2012-05-17 14:03 PDT, Tony Chang
no flags
Patch (71.66 KB, patch)
2012-05-17 14:50 PDT, Tony Chang
no flags
Archive of layout-test-results from ec2-cr-linux-03 (587.55 KB, application/zip)
2012-05-17 16:31 PDT, WebKit Review Bot
no flags
Patch for landing (100.97 KB, patch)
2012-05-18 09:30 PDT, Tony Chang
no flags
Tony Chang
Comment 1 2012-05-17 12:32:34 PDT
Tony Chang
Comment 2 2012-05-17 12:34:05 PDT
Tony Chang
Comment 3 2012-05-17 12:35:43 PDT
This will make it easier to work on grid layout (compiles everywhere, runs tests), but won't expose it to the web yet since it's still in flux. This is similar to the approach taken for regions in bug 78525.
Ojan Vafai
Comment 4 2012-05-17 13:52:57 PDT
Comment on attachment 142528 [details] Patch Would be good to put up a patch the properly patches in to see the EWS bots go green before committing. Up to you though.
Tony Chang
Comment 5 2012-05-17 14:03:05 PDT
WebKit Review Bot
Comment 6 2012-05-17 14:05:11 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Build Bot
Comment 7 2012-05-17 14:29:06 PDT
Tony Chang
Comment 8 2012-05-17 14:50:29 PDT
Darin Fisher (:fishd, Google)
Comment 9 2012-05-17 15:17:37 PDT
Comment on attachment 142560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142560&action=review > Source/WebKit/chromium/public/WebSettings.h:101 > + virtual void setExperimentalCSSGridLayoutEnabled(bool) = 0; LGTM for the Chromium WebKit API part
Tony Chang
Comment 10 2012-05-17 15:23:23 PDT
Thanks for the reviews. I'll land this once the bots go green. Hyatt also said this was fine on IRC: 14:03 < tony^work> dhyatt: Do you mind if we compile css3 grid layout by default, but turn it off at the CSS parser level? 14:03 < dhyatt> similar to regions? sure. 14:04 < tony^work> dhyatt: yes, exactly the same as regions: https://bugs.webkit.org/show_bug.cgi?id=86767
WebKit Review Bot
Comment 11 2012-05-17 16:31:19 PDT
Comment on attachment 142560 [details] Patch Attachment 142560 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12721638 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html
WebKit Review Bot
Comment 12 2012-05-17 16:31:24 PDT
Created attachment 142584 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Tony Chang
Comment 13 2012-05-18 09:30:59 PDT
Created attachment 142727 [details] Patch for landing
WebKit Review Bot
Comment 14 2012-05-18 12:29:31 PDT
Comment on attachment 142727 [details] Patch for landing Clearing flags on attachment: 142727 Committed r117613: <http://trac.webkit.org/changeset/117613>
WebKit Review Bot
Comment 15 2012-05-18 12:29:42 PDT
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 16 2012-05-18 13:37:20 PDT
Tony Chang
Comment 17 2012-05-18 13:38:33 PDT
(In reply to comment #16) > CMake option removed in http://trac.webkit.org/changeset/117618 Thanks!
Tony Chang
Comment 19 2012-05-22 10:12:53 PDT
Note You need to log in before you can comment on or make changes to this bug.